Fixed blobdescriptorservice unit test flake #13289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
|
@legionus could you give this a quick look please? |
|
I've extended the PR for a fix for a data race found in #13274. |
miminar
force-pushed
the
fix-flake-13288
branch
2 times, most recently
from
5d59364 to
fdfda0f
Compare
added 2 commits
March 15, 2017 15:24
Avoid a race when trying to delete just uploaded manifest. The purpose of the test is just to verify that our blobdescriptorservice is in use. Signed-off-by: Michal Minář <[email protected]>
Initialize the log level just once. Disable upload purging. Signed-off-by: Michal Minář <[email protected]>
miminar
force-pushed
the
fix-flake-13288
branch
from
fdfda0f to
0ca5955
Compare
|
Evaluated for origin test up to 0ca5955 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/235/) (Base Commit: 1eb44c7) |
|
@legionus may I ask for your merge powers? |
|
[merge] |
|
Evaluated for origin merge up to 0ca5955 |
|
It seems something went wrong. Please merge it. |
|
Nothing is wrong, the bot shows you are in the queue -- you must wait your turn to merge |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/115/) (Base Commit: 5b8b4dc) (Image: devenv-rhel7_6074) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid a race when trying to delete just uploaded manifest. The purpose of the
test is just to verify that our blobdescriptorservice is in use.
Resolves #13288