Adding generic build failed reason #13590
Conversation
|
[test] |
|
@openshift/devex ptal |
pkg/build/controller/controller.go
Outdated
| @@ -343,6 +343,10 @@ func (bc *BuildPodController) HandlePod(pod *kapi.Pod) error { | |||
|
|
|||
| case kapi.PodFailed: | |||
| nextStatus = buildapi.BuildPhaseFailed | |||
| if build.Status.Reason == "" { | |||
| build.Status.Reason = buildapi.StatusReasonGenericBuildFailed | |||
| build.Status.Message = "Generic Build failure - check logs for details." | |||
There was a problem hiding this comment.
make the message a constant too...
There was a problem hiding this comment.
Done, looking at a potential test case
|
[testextended][extended:core(builds)] |
Adding a generic build failed reason to display to display for build failures that do not have a more specific reason
|
Evaluated for origin test up to 2baacf1 |
|
continuous-integration/openshift-jenkins/test Running (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/521/) (Base Commit: 611176d) |
|
Evaluated for origin testextended up to 2baacf1 |
|
continuous-integration/openshift-jenkins/test SUCCESS |
|
continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/112/) (Base Commit: 611176d) (Extended Tests: core(builds)) |
|
@bparees ptal, all tests are passing |
|
[merge] |
|
flake #13594 |
|
[merge]
…On Fri, Mar 31, 2017 at 12:21 PM, OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/229/)
(Base Commit: 611176d
<611176d>
)
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#13590 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEvl3l6n8Avo7LdHJdyyy69EDPABvk4Eks5rrSgKgaJpZM4Mul5P>
.
--
Ben Parees | OpenShift
|
|
Evaluated for origin merge up to 2baacf1 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/230/) (Base Commit: a62d19f) (Image: devenv-rhel7_6109) |
Adding a generic build failed reason to display to display
for build failures that do not have a more specific reason
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1436391