UPSTREAM: 47731: Use endpoints informer for the endpoint controller. #15067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
|
Going to hold for 3.6.1 potentially [test] again |
aveshagarwal
force-pushed
the
master-issue-14710
branch
from
8afdf12 to
b0ab35e
Compare
|
Updated this PR after kube-1.7 rebase landed. |
|
Lgtm for 1.7, [merge] to get soak time on master |
|
continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 1 |
|
Evaluated for origin merge up to b0ab35e |
|
[test] |
|
Evaluated for origin test up to b0ab35e |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3392/) (Base Commit: 8833a3a) (PR Branch Commit: b0ab35e) |
openshift-merge-robot
added a commit
that referenced
this pull request
Sep 29, 2017
Automatic merge from submit-queue. Cherry-pick #15067 endpoints fixes. cc @sjenning @eparis @derekwaynecarr This is a cherry-pick of #15067 to prevent too-frequent processing of endpoint updates. https://bugzilla.redhat.com/show_bug.cgi?id=1481603 Here's the original text of #15067 as written by @aveshagarwal: > Fixes #14710 > > Note: I had to manually merge changes and due to this, the commits might not match exactly. > > It has following 2 complete upstream PRs: > kubernetes/kubernetes#47731 (with some modifications/additions). > kubernetes/kubernetes#47788 > > And one partial PR to make above PRs compile: > kubernetes/kubernetes#44408 (Edited to fix bz link -- originally sent with wrong bug)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@derekwaynecarr @smarterclayton
Fixes #14710
Note: I had to manually merge changes and due to this, the commits might not match exactly.
It has following 2 complete upstream PRs:
kubernetes/kubernetes#47731 (with some modifications/additions).
kubernetes/kubernetes#47788
And one partial PR to make above PRs compile:
kubernetes/kubernetes#44408