-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #15067 endpoints fixes. #16575
Cherry-pick #15067 endpoints fixes. #16575
Conversation
/unassign |
There has been a PR for this already #15343. I think I will close it now. |
Still seeing excessive write rates on endpoints on 3.6.1 #16583 |
@smarterclayton this patch should decrease updates for endpoints, although only as a byproduct. In my observations, the periodic re-checking of every service resulted in the non-update updates getting pushed out whenever a pod changed. With this fix, the endpoint controller will decide whether to update the endpoint whenever a pod event occurs. Without it, every 30 seconds every endpoint gets enqueued for sync, and that results in the non-update updates (i.e., changes only in the resource version of the target ref pod) being pushed out. |
/kind bug |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue. |
cc @sjenning @eparis @derekwaynecarr
This is a cherry-pick of #15067 to prevent too-frequent processing of endpoint updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1481603
Here's the original text of #15067 as written by @aveshagarwal:
(Edited to fix bz link -- originally sent with wrong bug)