Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #15067 endpoints fixes. #16575

Merged
merged 2 commits into from
Sep 29, 2017

Conversation

joelsmith
Copy link
Contributor

@joelsmith joelsmith commented Sep 27, 2017

cc @sjenning @eparis @derekwaynecarr

This is a cherry-pick of #15067 to prevent too-frequent processing of endpoint updates.

https://bugzilla.redhat.com/show_bug.cgi?id=1481603

Here's the original text of #15067 as written by @aveshagarwal:

Fixes #14710

Note: I had to manually merge changes and due to this, the commits might not match exactly.

It has following 2 complete upstream PRs:
kubernetes/kubernetes#47731 (with some modifications/additions).
kubernetes/kubernetes#47788

And one partial PR to make above PRs compile:
kubernetes/kubernetes#44408

(Edited to fix bz link -- originally sent with wrong bug)

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 27, 2017
@deads2k
Copy link
Contributor

deads2k commented Sep 27, 2017

/unassign
/assign eparis

@openshift-ci-robot openshift-ci-robot assigned eparis and unassigned deads2k Sep 27, 2017
@aveshagarwal
Copy link
Contributor

There has been a PR for this already #15343. I think I will close it now.

@smarterclayton
Copy link
Contributor

Still seeing excessive write rates on endpoints on 3.6.1 #16583

@joelsmith
Copy link
Contributor Author

@smarterclayton this patch should decrease updates for endpoints, although only as a byproduct.

In my observations, the periodic re-checking of every service resulted in the non-update updates getting pushed out whenever a pod changed. With this fix, the endpoint controller will decide whether to update the endpoint whenever a pod event occurs. Without it, every 30 seconds every endpoint gets enqueued for sync, and that results in the non-update updates (i.e., changes only in the resource version of the target ref pod) being pushed out.

@derekwaynecarr
Copy link
Member

/kind bug
/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 29, 2017
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit f7a367c into openshift:release-3.6 Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants