Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 47731: Use endpoints informer for the endpoint controller. #15343

Closed
wants to merge 3 commits into from
Closed

UPSTREAM: 47731: Use endpoints informer for the endpoint controller. #15343

wants to merge 3 commits into from

Conversation

aveshagarwal
Copy link
Contributor

@derekwaynecarr
Copy link
Member

[test]

FYI @smarterclayton @liggitt @eparis

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 4370d95

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3288/) (Base Commit: 12575c5) (PR Branch Commit: 4370d95)

1 similar comment
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3288/) (Base Commit: 12575c5) (PR Branch Commit: 4370d95)

@openshift-merge-robot openshift-merge-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 24, 2017
@aveshagarwal
Copy link
Contributor Author

@stevekuznetsov prow seems to be working extra hard on its first day, and insisting for approval every few minutes.

@aveshagarwal
Copy link
Contributor Author

As prow asked: /assign @smarterclayton

@stevekuznetsov
Copy link
Contributor

@aveshagarwal yeah, we found a bug in the approval code upstream -- considering a fix or rolling back that feature for now

@deads2k
Copy link
Contributor

deads2k commented Jul 25, 2017

/unassign

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017
@smarterclayton smarterclayton added this to the 3.6.x milestone Jul 28, 2017
@openshift-merge-robot openshift-merge-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aveshagarwal
We suggest the following additional approver: smarterclayton

Assign the PR to them by writing /assign @smarterclayton in a comment when ready.

Associated issue: 14710

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

@aveshagarwal PR needs rebase

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2017
@aveshagarwal aveshagarwal mentioned this pull request Sep 27, 2017
Merged
@aveshagarwal
Copy link
Contributor Author

Its been taken care in #16575 so closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarterclayton smarterclayton

Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v3.6
Development

Successfully merging this pull request may close these issues.
7 participants
@aveshagarwal @derekwaynecarr @openshift-bot @stevekuznetsov @deads2k @openshift-merge-robot @smarterclayton