Fix NodePort test

[danwinship]

Pulls in the k8s test utils fix from kubernetes/kubernetes#49025 to make the NodePort test work on non-cloud installs again.

Fixes #15253

[danwinship]

/assign deads2k
/test extended_networking

[danwinship]

The initial test run failed, but on further investigation, it was a pre-existing flake, #13108, not anything new. After adding a commit with a bit of debugging, it has passed multiple times...

[openshift-ci-robot]

@danwinship: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_networking	0ad4094	link	/test extended_networking

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[danwinship]

@stevekuznetsov some bot bugginess here: after I pushed some new commits, causing the tests to be rerun, it's now telling me that extended_networking failed... but it didn't actually re-run extended_networking, and the link points to an old test run that has since been GCed. (Which is probably the logs from the last time it did get run for this PR, but I don't know.)

[danwinship]

/retest

[stevekuznetsov]

Weird -- you will see the old link in the table while it edits it with new info, so it may seem new, but that should not have stuck around as we can see the networking test is green.

[stevekuznetsov]

@Kargakis maybe a github call failed?

[danwinship]

@stevekuznetsov extended_networking_minimal is green. It's complaining that the full extended_networking test failed, but it didn't run it again.

[0xmichalis]

Hrm, the extended_networking job seems to be always_run: false .... I guess we want it to run on every PR?

[0xmichalis]

For context, /retest is not working currenty for jobs that are not running by default (always_runs: true). There is an issue upstream but I can't seem to find it now.

[danwinship]

No, we don't want it to run on every PR; extended_networking_minimal should run on every test (which it does) and extended_networking should only run when requested. I did previously request that it be run here, and it did get run, but then when a retest happened after pushing a new commit, the bot seemed to get confused (claiming that the test had failed even though it hadn't even run again)

[stevekuznetsov]

Hmm yeah what you saw may have just been the bot refreshing the table -- it happens in those situations.

[0xmichalis]

Yeah, the stale comment is another known issue.

[danwinship]

@deads2k: master's open, can this get a lgtm?

[deads2k]

/lgtm

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, deads2k

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [deads2k]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[openshift-merge-robot]

Automatic merge from submit-queue (batch tested with PRs 16226, 16377, 15766, 16299, 16153)