Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NodePort test #15766

Merged
merged 3 commits into from
Sep 18, 2017
Merged

Fix NodePort test #15766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bd2fbb
UPSTREAM: 49025: fix NodePort test on baremetal installs
danwinship Aug 14, 2017
2746f59
UPSTREAM: <drop>: add debugging to NodePort test
danwinship Aug 14, 2017
c96875b
Re-enable NodePort test
danwinship Aug 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/extended/networking.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export SHELLOPTS
#
# The EmptyDir test is a canary; it will fail if mount propagation is
# not properly configured on the host.
NETWORKING_E2E_FOCUS="${NETWORKING_E2E_FOCUS:-etworking|Feature:OSNetworkPolicy|EmptyDir volumes should support \(root,0644,tmpfs\)}"
NETWORKING_E2E_FOCUS="${NETWORKING_E2E_FOCUS:-etworking|Services should be able to create a functioning NodePort service|Feature:OSNetworkPolicy|EmptyDir volumes should support \(root,0644,tmpfs\)}"
NETWORKING_E2E_SKIP="${NETWORKING_E2E_SKIP:-}"

DEFAULT_SKIP_LIST=(
Expand Down
3 changes: 0 additions & 3 deletions test/extended/util/test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,9 +298,6 @@ var (
`validates resource limits of pods that are allowed to run`, // SchedulerPredicates
`should idle the service and DeploymentConfig properly`, // idling with a single service and DeploymentConfig [Conformance]

// fails without a cloud provider
"should be able to create a functioning NodePort service",

// TODO undisable:
"should be schedule to node that don't match the PodAntiAffinity terms",
"should perfer to scheduled to nodes pod can tolerate",
Expand Down
4 changes: 4 additions & 0 deletions vendor/k8s.io/kubernetes/test/e2e/framework/service_util.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vendor/k8s.io/kubernetes/test/e2e/service.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.