hack in field selectors for 3.6

[deads2k]

This doesn't make any of the structural fixes to make field selectors more consistent and reliable across APIs, but it should enable compatible field selection in the 3.6 groupified APIs.

@bparees @gabemontero per request

[liggitt]

looks good enough to me

[deads2k]

looks good enough to me

"damning with faint praise" comes to mind... :)

[bparees]

/lgtm
but i think we need an ose equivalent backport for this to help anyone.

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, deads2k

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/OWNERS [bparees,deads2k]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[deads2k]

/retest

[deads2k]

@stevekuznetsov @bparees extended-builds failed, but this ended up in queue

[stevekuznetsov]

but this ended up in queue

What do you mean? Do you have some logs?

[stevekuznetsov]

Oh

[stevekuznetsov]

Builds are not blocking

[deads2k]

@csrwng can you help me sort out whether this error is real? I wouldn't expect to have changed anything for a test that used to work in 3.6.

[csrwng]

@deads2k this looks like a CI problem. In 3.6 not passing an arg would result in an error, but in 3.7 it only results in a warning. Looks like the builder image being used to run the test is a 3.7 one and not 3.6 (maybe latest?). But anyway not a real failure.

[bparees]

it was a docker change (how docker handled you not supplying an ARG that the dockerfile defined). It went from being an error to a warning.

We fixed the test in 3.7 when it broke (I guess when we updated docker at some point). We'll just need to backport the same fix to the 3.6 branch:

you should be able to just cherry pick this into your PR:
#16212

[openshift-ci-robot]

@deads2k: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_builds	ea49279	link	/test extended_builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[deads2k]

@bparees @csrwng I picked the one you pointed out. I don't want to keep holding this on existing CI problems. Is this another CI issue?

[csrwng]

@deads2k this one is actually a bug that we fixed post-3.6. But nothing related to this pull.

[bparees]

@deads2k we'll let you slide on that failure.

[openshift-merge-robot]

Automatic merge from submit-queue