-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python 3.6 S2I image to examples #17281
Add python 3.6 S2I image to examples #17281
Conversation
/unassign @jcantrill @dcbw |
thanks @alexcern you're going to need to run hack/update-generated-bindata.sh too. /approve |
/test image_ecosystem |
132a288
to
b3808f9
Compare
b3808f9
to
d905e38
Compare
Introduced with redhat-developer/s2i-dotnetcore#134
d905e38
to
d4a8e61
Compare
Thanks @bparees |
yeah i don't think the failures are related to your change. |
/retest |
/test image_ecosystem |
1 similar comment
/test image_ecosystem |
/test extended_image_ecosystem |
2 similar comments
/test extended_image_ecosystem |
/test extended_image_ecosystem |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexcern, bparees The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue (batch tested with PRs 17327, 17281). |
Automatic merge from submit-queue (batch tested with PRs 17327, 17281). Add python 3.6 S2I image to examples Python 3.6 S2I image was added by sclorg/s2i-python-container#215
@alexcern: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Python 3.6 S2I image was added by sclorg/s2i-python-container#215