Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.6 S2I image to examples #17281

Merged
merged 1 commit into from
Nov 16, 2017

Conversation

alexcern
Copy link
Contributor

Python 3.6 S2I image was added by sclorg/s2i-python-container#215

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2017
@bparees
Copy link
Contributor

bparees commented Nov 13, 2017

/unassign @jcantrill @dcbw
/assign

@openshift-ci-robot openshift-ci-robot assigned bparees and unassigned jcantrill and dcbw Nov 13, 2017
@bparees
Copy link
Contributor

bparees commented Nov 13, 2017

thanks @alexcern

you're going to need to run hack/update-generated-bindata.sh too.

/approve
/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 13, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2017
@bparees
Copy link
Contributor

bparees commented Nov 13, 2017

/test image_ecosystem

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2017
@alexcern
Copy link
Contributor Author

Thanks @bparees
I ran hack/update-generated-bindata.sh and rebased but some tests still fail. I'm not sure what to do next as no failure seems related to the change.

@bparees
Copy link
Contributor

bparees commented Nov 14, 2017

yeah i don't think the failures are related to your change.
/retest

@bparees
Copy link
Contributor

bparees commented Nov 14, 2017

/retest

@bparees
Copy link
Contributor

bparees commented Nov 14, 2017

/test image_ecosystem

1 similar comment
@bparees
Copy link
Contributor

bparees commented Nov 15, 2017

/test image_ecosystem

@bparees
Copy link
Contributor

bparees commented Nov 15, 2017

/test extended_image_ecosystem

2 similar comments
@bparees
Copy link
Contributor

bparees commented Nov 15, 2017

/test extended_image_ecosystem

@bparees
Copy link
Contributor

bparees commented Nov 15, 2017

/test extended_image_ecosystem

@bparees
Copy link
Contributor

bparees commented Nov 15, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcern, bparees

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17327, 17281).

openshift-merge-robot added a commit that referenced this pull request Nov 16, 2017
Automatic merge from submit-queue (batch tested with PRs 17327, 17281).

Add python 3.6 S2I image to examples

Python 3.6 S2I image was added by sclorg/s2i-python-container#215
@openshift-merge-robot openshift-merge-robot merged commit 9e126dc into openshift:master Nov 16, 2017
@openshift-ci-robot
Copy link

@alexcern: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_update d4a8e61 link /test extended_conformance_install_update
ci/openshift-jenkins/extended_conformance_gce d4a8e61 link /test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

alexcern added a commit to alexcern/openshift-ansible that referenced this pull request Nov 20, 2017
alexcern added a commit to alexcern/openshift-ansible that referenced this pull request Nov 20, 2017
dav1x pushed a commit to dav1x/openshift-ansible that referenced this pull request Jan 15, 2018
leseb pushed a commit to leseb/openshift-ansible that referenced this pull request Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants