-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce version 3.6 - rebased #215
Conversation
Can one of the admins verify this patch? |
[test] |
Can one of the admins verify this patch? |
Looks good to me, thanks @chrisburr! Unless there are any objections, I'll merge this. |
@chrisburr Please add the 3.6 version string into the Makefile over at: If this is not set the CI tests are not run against the new version (and having |
Also needs a rebase before being able to be merged |
c61aa94
to
2591e92
Compare
2591e92
to
3421404
Compare
@pkubatrh Done |
[test] |
Seems like the 3.6 scl rpms are already in |
[test] |
Tests are green now, thanks! LGTM. |
Automatic merge from submit-queue (batch tested with PRs 17327, 17281). Add python 3.6 S2I image to examples Python 3.6 S2I image was added by sclorg/s2i-python-container#215
This PR is simply #208 rebased to fix the conflicts with an additional commit to address the comments of @torsava.
If you would rather close this and rebase/merge #208 instead I am be happy with that, I just did this as I needed to build an image using Python 3.6.