Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: Use Requires: git-core if distribution is new enough #18538

Closed
wants to merge 1 commit into from

Conversation

cgwalters
Copy link
Member

I am planning to propose we include origin-clients in Fedora Atomic
Workstation by default.

It was pointed out that that pulls in git which pulls in Perl. A
while ago we added a git-core which is really all we need:
https://bugzilla.redhat.com/show_bug.cgi?id=1161251

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cgwalters
We suggest the following additional approver: stevekuznetsov

Assign the PR to them by writing /assign @stevekuznetsov in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2018
I am planning to propose we include `origin-clients` in Fedora Atomic
Workstation by default.

It was pointed out that that pulls in `git` which pulls in Perl.  A
while ago we added a `git-core` which is really all we need:
https://bugzilla.redhat.com/show_bug.cgi?id=1161251
@jlebon
Copy link
Member

jlebon commented Apr 19, 2018

Can someone take a look at this? It seems minor, though it'd make origin-clients even more attractive for folks trying to keep a minimal base OS.

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2018
@openshift-bot
Copy link
Contributor

/test cross

@dustymabe
Copy link
Member

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 9, 2018

@cgwalters: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_networking_minimal cb73679 link /test extended_networking_minimal
ci/openshift-jenkins/cross cb73679 link /test cross
ci/prow/gcp cb73679 link /test gcp
ci/prow/cross cb73679 link /test cross

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 8, 2018
@jlebon
Copy link
Member

jlebon commented Oct 11, 2018

Looks like we can close this? The dep was completely dropped in #19509.

@cgwalters cgwalters closed this Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants