Split up the openshift image content to reduce total size. #19509
Conversation
openshift-ci-robot
added
approved
smarterclayton
force-pushed
the
purge
branch
2 times, most recently
from
7ac0cf9 to
4464d84
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
size/XXL
smarterclayton
force-pushed
the
purge
branch
6 times, most recently
from
e80e74e to
22a18d2
Compare
|
/retest |
|
I think openshift/origin-cli needs to be added to hack/build-local-images.py for the catalog job. |
|
/test gcp |
smarterclayton
force-pushed
the
purge
branch
3 times, most recently
from
167bb04 to
2b7b4a3
Compare
|
Exact description of image changes in this PR, targeted for 3.10 @jupierce @adammhaile @smunilla
Ansible is already updated to avoid the removed images. |
|
@smarterclayton Thanks for the heads up. If possible can we hold off on a merge until I can further update my PR to reflect these changes? As previously discussed I already PR'd the change to remove the STI image but this goes much beyond that. So I would like to have our end entirely ready as this will surely break our 3.10 build. |
|
@smarterclayton @jupierce - Looking into these changes further and I have some questions and housekeeping before I can start making changes to our automation:
|
These are in origin, whatever you do for origin sub packages. |
There is no impact, the reparenting is just a detail.
Right now openshift3/ose is aliased to openshift3/ose-control-plane. So you could leave that as is for now, but ose-control-plane == ose |
Breaks dependencies on the entire controller manager and apiserver stack in oc. Config diagnostics were of questionable value, validation was deprecated and experimental.
Move it closer to where we need to test it (config package doesn't bring those dependencies into scope anymore).
Move the dependency into the master startup flow.
Instead of calling the apiserver code, clear status. Mark deprecated in favor of oc get --export (which itself is now of questionable value). A future release should provide better logic for stripping out unnecessary fields.
Do not remove openshift binary from the node image quite yet.
|
New changes are detected. LGTM label has been removed. |
|
/test launch-gcp |
Will restore in the future. Also reduce logging level on tests below the unintelligible threshold.
|
Fixed the last service catalog issue, @jpeeler i grabbed two fixes from Jay's PR (but not all of them). This is blocking other changes. |
smarterclayton
added
the
priority/critical-urgent
|
@smarterclayton I see you grabbed the change for the configmap resource lock, but not the RBAC for that resource. Am I missing something? FWIW, #19568 is in the merge pool now. |
|
/retest |
|
/refresh |
|
/skip |
|
Green buttoning since we need to make the split happen. |
As a result of openshift#19509, packages `iptables`, `ethtool`, and `socat` ended up being defined twice for `yum install`. This removes duplicate packages in the same command
Key changes
openshift/originandopenshift/node(no longer supported)hypershiftandhyperkubeandocto their own imagescontrol-planedepend oncliocand the server.ocbinary from 220M to 110M.oc exportin favor ofoc get --export(remove the server dependency)openshift start nodeby creatingopenshift-node-configwhich takesnode-config.yamland writes out kubelet flags (a future PR will switch ansible to use this)docker-buildimage (same content in both) which will prepare to later split the build binary out.--checkflag.openshift-sdninto its own binary by cutting dependencies with the master.@deads2k getting very close...