-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run extended tests post-rebase #19260
Conversation
/unassign |
@openshift/sig-storage can you take a look at the extended failures in https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/19260/test_pull_request_origin_extended_conformance_gce/18727/? seeing these new ones after 1.10 came in:
can you determine whether those require additional setup in origin tests, or are alpha features that are not enabled by default? |
Logs:
Hmm, we need either newer docker from RHEL 7.5 or our own custom systemd service for it. How can we do that? |
That's actually a regresssion, Kubernetes requires newer git than it's in RHEL 7.
|
There is typo in image name: Edit: it's already fixed upstream, Origin PR: #19292 |
+ fix lot of storage tests.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@liggitt: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
`Cinder`, // requires an OpenStack cluster | ||
// See the CanSupport implementation in upstream to determine wether these work. | ||
`Ceph RBD`, // Works if ceph-common Binary installed (but we can't guarantee this on all clusters). | ||
`GlusterFS`, // May work if /sbin/mount.glusterfs to be installed for plugin to work (also possibly blocked by serial pulling) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand how the list of unsupported volume tests is created.
-
AWS and GCE are not listed, while OpenStack Cinder is. Why can't anyone run the tests on OpenStack? BTW, all storage test should have proper
framework.SkipUnlessProviderIs("xyz")
and bothvsphere
andcinder
should be included in the test (i.e. excluded from this list), at least when it comes to storage tests. -
Gluster and Ceph RBD are listed, while CephFS and NFS and iSCSI is not. All of these need something installed on the host. Note that these tests are not skipped automatically if appropriate tools are missing (iscsiadm, /bin/rbd, mount.glusterfs...)
You should skip either all of them or none.
There is a possibility to run these dependencies in containers, so the tests could eventually run everywhere, but it needs a separate test suite that runs these containers and enables appropriate feature. For now, I would add to the skip list at leastSCSI
andCeph
(that will match both CephFS and Ceph RBD), hoping thatmount.nfs
is always installed
origin PR: #19359 |
pick of #18816 on top of #19137