Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run extended tests post-rebase #19260

Closed
wants to merge 3 commits into from
Closed

run extended tests post-rebase #19260

wants to merge 3 commits into from

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Apr 7, 2018

pick of #18816 on top of #19137

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 7, 2018
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 7, 2018
@liggitt liggitt mentioned this pull request Apr 7, 2018
51 tasks
@stevekuznetsov
Copy link
Contributor

/unassign

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 9, 2018
@liggitt
Copy link
Contributor Author

liggitt commented Apr 9, 2018

@openshift/sig-storage can you take a look at the extended failures in https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/19260/test_pull_request_origin_extended_conformance_gce/18727/?

seeing these new ones after 1.10 came in:

  • [sig-storage] CSI Volumes [Feature:CSI] Sanity CSI plugin test using hostPath CSI driver should provision storage with a hostPath CSI driver [Suite:openshift/conformance/parallel] [Suite:k8s]
  • [sig-storage] EmptyDir wrapper volumes should not conflict [Suite:openshift/conformance/parallel] [Suite:k8s]
  • [sig-storage] Volumes iSCSI [Feature:Volumes] should be mountable [Suite:openshift/conformance/parallel] [Suite:k8s]

can you determine whether those require additional setup in origin tests, or are alpha features that are not enabled by default?

@liggitt liggitt changed the title WIP: rebase + extra extended tests run extended tests post-rebase Apr 9, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 9, 2018
@jsafrane
Copy link
Contributor

CSI Volumes [Feature:CSI] Sanity CSI plugin test using hostPath CSI driver should provision storage with a hostPath CSI driver

Logs:

Failed: Error: failed to start container "hostpath-driver": Error response from daemon: linux mounts: Path /var/lib/kubelet/pods is mounted on / but it is not a shared mount.

Hmm, we need either newer docker from RHEL 7.5 or our own custom systemd service for it. How can we do that?

@jsafrane
Copy link
Contributor

EmptyDir wrapper volumes should not conflict

That's actually a regresssion, Kubernetes requires newer git than it's in RHEL 7.
This can be fixed relatively easily. It will break mount containers, but git volume has been deprecated upstream, so we probably don't care.

FailedMount: MountVolume.SetUp failed for volume "git-volume" : failed to exec 'git clone http://172.30.8.217:2345 test': Unknown option: -C

Filled https://bugzilla.redhat.com/show_bug.cgi?id=1565553

@jsafrane
Copy link
Contributor

jsafrane commented Apr 10, 2018

Volumes iSCSI [Feature:Volumes] should be mountable

There is typo in image name: k8s.gcr.io/volume-icsci:0.1. I'll fix it upstream and in Origin.

Edit: it's already fixed upstream, Origin PR: #19292

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@liggitt: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_builds 4f19ab3 link /test extended_builds
ci/openshift-jenkins/end_to_end 9bb0786 link /test end_to_end
ci/openshift-jenkins/cmd 9bb0786 link /test cmd
ci/openshift-jenkins/gcp 9bb0786 link /test gcp
ci/openshift-jenkins/extended_conformance_install 9bb0786 link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

`Cinder`, // requires an OpenStack cluster
// See the CanSupport implementation in upstream to determine wether these work.
`Ceph RBD`, // Works if ceph-common Binary installed (but we can't guarantee this on all clusters).
`GlusterFS`, // May work if /sbin/mount.glusterfs to be installed for plugin to work (also possibly blocked by serial pulling)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how the list of unsupported volume tests is created.

  • AWS and GCE are not listed, while OpenStack Cinder is. Why can't anyone run the tests on OpenStack? BTW, all storage test should have proper framework.SkipUnlessProviderIs("xyz") and both vsphere and cinder should be included in the test (i.e. excluded from this list), at least when it comes to storage tests.

  • Gluster and Ceph RBD are listed, while CephFS and NFS and iSCSI is not. All of these need something installed on the host. Note that these tests are not skipped automatically if appropriate tools are missing (iscsiadm, /bin/rbd, mount.glusterfs...)
    You should skip either all of them or none.
    There is a possibility to run these dependencies in containers, so the tests could eventually run everywhere, but it needs a separate test suite that runs these containers and enables appropriate feature. For now, I would add to the skip list at least SCSI and Ceph (that will match both CephFS and Ceph RBD), hoping that mount.nfs is always installed

@jsafrane
Copy link
Contributor

EmptyDir wrapper volumes should not conflict

origin PR: #19359

@liggitt liggitt closed this May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/post-rebase sig/storage size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants