Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 62394: Revert "git: Use VolumeHost.GetExec() to execute stuff in volume plugins" #19359

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Apr 16, 2018

RHEL 7 has old git so we should pick this PR to restore git volume functionality.

Upstream PR: kubernetes/kubernetes#62394

/assign @gnufied @rootfs @tsmetana
https://bugzilla.redhat.com/show_bug.cgi?id=1565553

…ff in volume plugins"

RHEL 7 has old git so we should pick this PR to restore git volume functionality.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2018
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 16, 2018
@tsmetana
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, tsmetana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2018
@jsafrane
Copy link
Contributor Author

Fixed commit message to the right format.

@jsafrane jsafrane changed the title UPSTREAM: 62394" Revert "git: Use VolumeHost.GetExec() to execute stuff in volume plugins" UPSTREAM: 62394: Revert "git: Use VolumeHost.GetExec() to execute stuff in volume plugins" Apr 16, 2018
@jsafrane
Copy link
Contributor Author

/retest

@jsafrane
Copy link
Contributor Author

@gnufied @tsmetana PTAL

@gnufied
Copy link
Member

gnufied commented Apr 24, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2018
@openshift-merge-robot openshift-merge-robot merged commit 053c409 into openshift:master Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants