Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shrink openapi package size #19512

Merged
merged 2 commits into from
Apr 25, 2018
Merged

Shrink openapi package size #19512

merged 2 commits into from
Apr 25, 2018

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Apr 25, 2018 •
edited
Loading

bumps to pick up kube-openapi generation change

binary before after
hyperkube 273MB 230MB
hypershift 333MB 250MB
openshift 357MB 273MB

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2018
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 25, 2018
@bparees bparees removed their request for review April 25, 2018 16:34
@liggitt
Copy link
Contributor Author

liggitt commented Apr 25, 2018

/assign @smarterclayton

failed tests are failing across PRs with identical errors

@liggitt liggitt mentioned this pull request Apr 25, 2018
Merged
@liggitt
Copy link
Contributor Author

liggitt commented Apr 25, 2018

/retest

@deads2k
Copy link
Contributor

deads2k commented Apr 25, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2018
@deads2k deads2k mentioned this pull request Apr 25, 2018
Merged
@openshift-ci-robot
Copy link

@liggitt: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install 2816359 link /test extended_conformance_install
ci/openshift-jenkins/extended_image_ecosystem 2816359 link /test extended_image_ecosystem
ci/openshift-jenkins/extended_builds 2816359 link /test extended_builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt
Copy link
Contributor Author

liggitt commented Apr 25, 2018

blocking tests are green, nothing merged to master since they ran, merging

@liggitt liggitt merged commit a7199cf into openshift:master Apr 25, 2018
@liggitt liggitt deleted the openapi-size branch April 25, 2018 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@smarterclayton smarterclayton

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liggitt @openshift-ci-robot @deads2k @smarterclayton