Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 62913: make a simple dynamic client that is easy to use #19515

Merged
merged 1 commit into from
Apr 27, 2018
Merged

UPSTREAM: 62913: make a simple dynamic client that is easy to use #19515

merged 1 commit into from
Apr 27, 2018

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 25, 2018

no conflicts? Unpossible.

@bparees

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2018
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 25, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Apr 25, 2018

/hold

@liggitt says he's bumping.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2018
@liggitt
Copy link
Contributor

liggitt commented Apr 25, 2018 •
edited
Loading

bump PR is #19512

@deads2k
Copy link
Contributor Author

deads2k commented Apr 25, 2018

/retest

@bparees
Copy link
Contributor

bparees commented Apr 25, 2018

so should this be closed?

@liggitt
Copy link
Contributor

liggitt commented Apr 25, 2018

no, not a rebase, just bumping the vendored origin/kubernetes, and wanted to hold UPSTREAM commits to avoid confusing the bot (and me)

@deads2k
Copy link
Contributor Author

deads2k commented Apr 25, 2018

/retest

@liggitt
Copy link
Contributor

liggitt commented Apr 25, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Apr 25, 2018

/retest

1 similar comment
@deads2k
Copy link
Contributor Author

deads2k commented Apr 26, 2018

/retest

@bparees
Copy link
Contributor

bparees commented Apr 26, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2018
@soltysh
Copy link
Contributor

soltysh commented Apr 26, 2018

/retest

1 similar comment
@mfojtik
Copy link
Contributor

mfojtik commented Apr 27, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit d3558d1 into openshift:master Apr 27, 2018
@deads2k deads2k deleted the client-01-dynamic branch July 3, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@sttts sttts Awaiting requested review from sttts

Assignees

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@deads2k @openshift-ci-robot @liggitt @bparees @soltysh @mfojtik @openshift-merge-robot