Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[diagnostics] Use masterConfig in a field member of MasterConfigCheck struct #19562

Closed
wants to merge 1 commit into from
Closed

[diagnostics] Use masterConfig in a field member of MasterConfigCheck struct #19562

wants to merge 1 commit into from

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Apr 30, 2018

Although masterConfig was set in a filed of MasterConfigCheck at
complete():

the set value is not used, but used from util.go's global value:

results := configvalidation.ValidateMasterConfig(masterConfig, nil)

(though I think that there is no remarkable issue due to this at this
moment) this patch updates to use proper value.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nak3
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: liggitt

Assign the PR to them by writing /assign @liggitt in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2018
@openshift-bot
Copy link
Contributor

@nak3: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2018
@nak3
Copy link
Contributor Author

nak3 commented May 29, 2018

Closing as #19509 deleted the code.

@nak3 nak3 closed this May 29, 2018
@nak3 nak3 deleted the diag-masterconfig branch May 29, 2018 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants