Remove the node from dnsmasq config when shutting down #19987
Conversation
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/L
smarterclayton
requested review from
knobunc
and removed request for
liggitt and
juanvallejo
|
Well, at least I know I broke DNS. |
| @@ -115,14 +116,26 @@ var networkLong = templates.LongDesc(` | |||
|
|
|||
| // NewCommandStartNetwork provides a CLI handler for 'start network' command | |||
| func NewCommandStartNetwork(basename string, out, errout io.Writer) (*cobra.Command, *NodeOptions) { | |||
| options := &NodeOptions{Output: out} | |||
| options := &NodeOptions{ | |||
| ExpireDays: crypto.DefaultCertificateLifetimeInDays, | |||
There was a problem hiding this comment.
You can't start openshift start network anymore without args - someone broke it in a refactor at some point in the last month or so.
| interrupt.New(func(s os.Signal) { | ||
| close(ch) | ||
| fmt.Fprintf(errout, "interrupt: Gracefully shutting down ...\n") | ||
| time.Sleep(200 * time.Millisecond) |
There was a problem hiding this comment.
This is much better than 1 second?
There was a problem hiding this comment.
5 times better.
|
/test launch-gcp |
|
This is not ready to merge, there are failing tests. |
|
/test launch-gcp |
|
/test extended_conformance_install |
|
/test unit |
|
Ok, unit tests are fine. @liggitt I need to make sure I pick a port number that won't get used in the near future on the kubelet. |
|
/retest |
|
/lgtm |
Allow graceful shutdown of the DNS server so that we can remove ourselves from dnsmasq.
This prevents dnsmasq from timing out trying to talk to us.
This was a regression from 3.9
|
@liggitt moved it to 11256 and added a comment |
|
/retest |
|
/retest
…On Thu, Jun 14, 2018 at 12:29 PM, OpenShift CI Robot < ***@***.***> wrote:
@smarterclayton <https://github.com/smarterclayton>: The following test
*failed*, say /retest to rerun them all:
Test name Commit Details Rerun command
ci/prow/unit f8d0494
<f8d0494>
link
<https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/19987/pull-ci-origin-unit/201/> /test
unit
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19987 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_pwSWj5KQMkiJY-EsAMZZ4lwbXzKUks5t8o9RgaJpZM4UlJTn>
.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knobunc, liggitt, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/cherrypick release-3.10 |
|
@sdodson: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-3.10 and openshift-cherrypick-robot:cherry-pick-19987-to-release-3.10"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Nevermind, already on release-3.10, just waiting on an ocp build. |
Prevents dnsmasq from pending a dead server when the network pod dies or is interrupted. Also prevents us serving DNS before our caches fill.
https://bugzilla.redhat.com/show_bug.cgi?id=1584995