Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor blueprint route validation and generate events on errors #20722

Closed
wants to merge 1 commit into from
Closed

Refactor blueprint route validation and generate events on errors #20722

wants to merge 1 commit into from

Conversation

ramr
Copy link
Contributor

@ramr ramr commented Aug 21, 2018 •
edited
Loading

As per #20646 follow up to refactor the validation and generate events on errors.

/cc @openshift/sig-network-edge

Edited Update PR to remove event generation code as per the standup discussion.

@openshift-ci-robot openshift-ci-robot added sig/network-edge size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 21, 2018
ironcladlou
ironcladlou reviewed Aug 21, 2018
View reviewed changes
Copy link
Contributor

@ironcladlou ironcladlou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great- just one tiny thing

pkg/router/template/configmanager/haproxy/blueprint_plugin.go Outdated

if _, err := p.client.Events(route.Namespace).Create(e); err != nil {
glog.Errorf("adding blueprint route error event: %v", err)
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superfluous return

pravisankar
pravisankar approved these changes Aug 22, 2018
View reviewed changes
Copy link

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2018
pravisankar
pravisankar reviewed Aug 22, 2018
View reviewed changes
Copy link

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Test case need to be fixed.
Test Failure:
[WARNING] go test had the following output to stderr:
[WARNING] # github.com/openshift/origin/pkg/router/template/configmanager/haproxy
[WARNING] pkg/router/template/configmanager/haproxy/blueprint_plugin_test.go:102:30: not enough arguments in call to NewBlueprintPlugin
[WARNING] have (*fakeConfigManager)
[WARNING] want (templaterouter.ConfigManager, "github.com/openshift/origin/vendor/k8s.io/client-go/kubernetes/typed/core/v1".CoreV1Interface)
[WARNING] pkg/router/template/configmanager/haproxy/blueprint_plugin_test.go:140:30: not enough arguments in call to NewBlueprintPlugin
[WARNING] have (*fakeConfigManager)
[WARNING] want (templaterouter.ConfigManager, "github.com/openshift/origin/vendor/k8s.io/client-go/kubernetes/typed/core/v1".CoreV1Interface)
[WARNING] pkg/router/template/configmanager/haproxy/blueprint_plugin_test.go:179:30: not enough arguments in call to NewBlueprintPlugin
[WARNING] have (*fakeConfigManager)
[WARNING] want (templaterouter.ConfigManager, "github.com/openshift/origin/vendor/k8s.io/client-go/kubernetes/typed/core/v1".CoreV1Interface)
[WARNING] pkg/router/template/configmanager/haproxy/blueprint_plugin_test.go:196:30: not enough arguments in call to NewBlueprintPlugin
[WARNING] have (*fakeConfigManager)
[WARNING] want (templaterouter.ConfigManager, "github.com/openshift/origin/vendor/k8s.io/client-go/kubernetes/typed/core/v1".CoreV1Interface)

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2018
@ramr ramr force-pushed the blueprint-extval-followup branch from ce74c06 to f2bbf2c Compare August 22, 2018 20:54
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 22, 2018
@ramr
Copy link
Contributor Author

ramr commented Aug 22, 2018

/retest

1 similar comment
@pravisankar
Copy link

/retest

@ramr
Copy link
Contributor Author

ramr commented Oct 25, 2018

/test all

@ramr
Copy link
Contributor Author

ramr commented Oct 29, 2018

/retest

1 similar comment
@ramr
Copy link
Contributor Author

ramr commented Nov 26, 2018

/retest

pravisankar
pravisankar approved these changes Nov 27, 2018
View reviewed changes
Copy link

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pravisankar, ramr
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rajatchopra

If they are not already assigned, you can assign the PR to them by writing /assign @rajatchopra in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pravisankar
Copy link

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2018
@openshift-ci-robot
Copy link

@ramr: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2018
@openshift-ci-robot
Copy link

@ramr: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_clusterup f2bbf2c link /test extended_clusterup
ci/openshift-jenkins/extended_conformance_install f2bbf2c link /test extended_conformance_install
ci/prow/e2e-gcp-crio f2bbf2c link /test e2e-gcp-crio
ci/prow/launch-aws f2bbf2c link /test launch-aws
ci/prow/e2e-aws-serial f2bbf2c link /test e2e-aws-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramr ramr mentioned this pull request Feb 5, 2019
Merged
@ramr
Copy link
Contributor Author

ramr commented Feb 5, 2019

Closing this out as the router code moved to another repo and a new PR was opened for this.
Superseded by openshift/router#10

@ramr ramr closed this Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironcladlou ironcladlou ironcladlou left review comments

@pravisankar pravisankar pravisankar approved these changes

Assignees

@pravisankar pravisankar

Labels
lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/network-edge size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ramr @pravisankar @openshift-ci-robot @ironcladlou