Refactor haproxy router config manager blueprint validation code.

[ramr]

Follow up to refactor the blueprint validation code.

Migrated from: openshift/origin#20722

[Miciah]

What's up with the return value of AddBlueprint? Was that change supposed to be in this PR? Should (p *BlueprintPlugin) HandleRoute be changed to handle the error return?

[openshift-merge-robot]

/retest

[openshift-merge-robot]

/retest

[ramr]

What's up with the return value of AddBlueprint? Was that change supposed to be in this PR?
Should (p *BlueprintPlugin) HandleRoute be changed to handle the error return?

Missed that - good catch. Yeah, HandleRoute should propogate that error up. So the old pr went thru' some iterations where it was generating events in here and then we dropped that, so the error handling needed to propogate errors back (on blueprint add).

[Miciah]

With (p *BlueprintPlugin) HandleRoute propagating the error from AddBlueprint, (c *RouterController) processRoute will log it, right? Do we still need the glog.Errorf in AddBlueprint?

[ramr]

With (p *BlueprintPlugin) HandleRoute propagating the error from AddBlueprint, (c *RouterController) processRoute will log it, right? Do we still need the glog.Errorf in AddBlueprint?

I think it should - will check that next week and if so, remove it. Thx

[Miciah]

/lgtm

[openshift-ci-robot]

@Miciah: changing LGTM is restricted to assignees, and only openshift/router repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ramr]

/retest

[ramr]

@ironcladlou PTAL needs approval. Thx

[ironcladlou]

/approve

[ironcladlou]

/lgtm

[openshift-ci-robot]

@ironcladlou: changing LGTM is restricted to assignees, and only openshift/router repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knobunc]

@smarterclayton Do you know why this PR hates @Miciah and @ironcladlou?

/lgtm

[openshift-ci-robot]

@knobunc: changing LGTM is restricted to assignees, and only openshift/router repo collaborators may be assigned issues.

In response to this:

@smarterclayton Do you know why this PR hates @Miciah and @ironcladlou?

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pweil-]

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, knobunc, Miciah, pweil-, ramr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/router/OWNERS [pweil-]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ramr]

/retest

error was: level=fatal msg="failed to fetch Terraform Variables: failed to fetch dependency of \"Terraform Variables\": failed to fetch dependency of \"Cluster ID\": failed to fetch dependency of \"Install Config\": failed to fetch dependency of \"Base Domain\": failed to generate asset \"Platform\": EOF" �[0G�[2K�[1;92m? �[1;99mPlatform [Use arrows to move, type to filter]

[ramr]

/retest