-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Test Overhaul #7762
base: master
Are you sure you want to change the base?
Docker Test Overhaul #7762
Conversation
Signed-off-by: Derek Nola <[email protected]>
2e8a71f
to
153e521
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7762 +/- ##
=======================================
Coverage 23.02% 23.02%
=======================================
Files 34 34
Lines 3501 3501
=======================================
Hits 806 806
Misses 2647 2647
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1a83951
to
6838596
Compare
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]> x Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]> xx Signed-off-by: Derek Nola <[email protected]>
6838596
to
8b53473
Compare
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
da66caa
to
4e87bc8
Compare
Signed-off-by: Derek Nola <[email protected]>
4e87bc8
to
7bf2ade
Compare
Two general questions: |
Multus was a dead end on migration, it requires a macvlan network and I don't want deal with the issues of setting this up in docker. |
|
@@ -114,7 +180,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
etest: [dnscache, kine] | |||
etest: [dnscache, kine, ciliumnokp, multus] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a miss-spelled cilium ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, its a shorthand for "cilium no kube-proxy".
Proposed Changes
Types of Changes
CI/Tests
Verification
New Test Suite CI is green
Testing
Linked Issues
#7795
#7796
User-Facing Change
Further Comments