Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Test Overhaul #7762

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Feb 13, 2025

Proposed Changes

  • Move to rancher/systemd for docker container base. Enables install and restart of RKE2 service, enable complex testing cases.
  • Migrate old docker basics test into new go test framework using ginkgo/gomega
  • Migrate secretsencryption and splitserver E2E tests to Docker tests
  • Expand existing E2E tests that can run in CI (all 1 server + 1 agent tests)

Types of Changes

CI/Tests

Verification

New Test Suite CI is green

Testing

Linked Issues

#7795
#7796

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner February 13, 2025 23:12
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.02%. Comparing base (0917b55) to head (7bf2ade).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7762   +/-   ##
=======================================
  Coverage   23.02%   23.02%           
=======================================
  Files          34       34           
  Lines        3501     3501           
=======================================
  Hits          806      806           
  Misses       2647     2647           
  Partials       48       48           
Flag Coverage Δ
inttests 8.76% <ø> (ø)
unittests 16.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola force-pushed the docker_systemd branch 6 times, most recently from 1a83951 to 6838596 Compare February 14, 2025 19:23
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>

x

Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>

xx

Signed-off-by: Derek Nola <[email protected]>
@dereknola dereknola force-pushed the docker_systemd branch 2 times, most recently from da66caa to 4e87bc8 Compare February 19, 2025 18:31
@dereknola dereknola changed the title [WIP] Docker Test Overhaul Docker Test Overhaul Feb 20, 2025
@manuelbuil
Copy link
Contributor

manuelbuil commented Feb 20, 2025

Two general questions:
1 - You say "migrate" but you are not removing the old tests, right? Are we keeping both for a while?
2 - I remember you wanted to migrate the multus test too, which is awesome! Will that come in another I have just seen the commit Expand E2E matrix, sorry!

@dereknola
Copy link
Member Author

Multus was a dead end on migration, it requires a macvlan network and I don't want deal with the issues of setting this up in docker.

@dereknola
Copy link
Member Author

  1. Correct, I might remove them in the next PR. I actively use the VM setup so I'm keeping it around for a while.

@@ -114,7 +180,7 @@ jobs:
strategy:
fail-fast: false
matrix:
etest: [dnscache, kine]
etest: [dnscache, kine, ciliumnokp, multus]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a miss-spelled cilium ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, its a shorthand for "cilium no kube-proxy".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants