Remove RBAC console template #7120
Conversation
openshift-ci-robot
added
the
size/M
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
The origin-web-console-server and origin changes have merged. @sdodson PTAL /retest |
openshift-ci-robot
removed
the
do-not-merge/hold
spadgett
force-pushed
the
remove-console-rbac
branch
from
117f75e to
ceb41f0
Compare
|
/retest |
|
/lgtm |
|
/test containerized |
|
Not obvious to me why the console failed in that job, seems like it may've been crashlooping. |
Ideally you would remove the role binding and cluster role we were previously creating, although they won't break anything if they're there. It just gives the console a little more access than it needs (read permission on cluster service brokers).
Yeah, me either. Is it possibly using an old origin-web-console image? #7132 would help :/ |
spadgett
force-pushed
the
remove-console-rbac
branch
from
ceb41f0 to
49dfe62
Compare
|
Rebased to pick up #7132 for debugging the test failures |
openshift-merge-robot
removed
the
lgtm
|
@sdodson The containerized tests are failing because they're using an old image: |
|
Ok, so CI is setting the image tag for containerized installs, it'd be fixed if we overrided to 'latest' tag in CI or we tag a new image. @smarterclayton do you know when we'll next tag next? |
|
On the bright side, what we log now on console failures is extremely useful |
|
@sdodson We've switching to pushing to a v3.9 tag, so I don't think there will be any more v3.9.0-alpha tags |
|
@sdodson Following up on this... It seems to me the tests should be using the v3.9 tag if possible. |
|
/retest |
|
@spadgett Got the CI changes that force image tag of 'latest' on master branch PR CI jobs, can you rebase? |
The console is changing to discover if the template service broker is running by looking at the service classes on the client. This means the console no longer needs the RBAC template. It also no longer needs to manually trigger a rollout after the template service broker is installed or removed.
spadgett
force-pushed
the
remove-console-rbac
branch
from
49dfe62 to
4559402
Compare
|
@sdodson thanks, rebased |
|
/retest |
|
/test containerized |
|
/retest |
|
/cherrypick release-3.9 |
|
@spadgett: once the present PR merges, I will cherry-pick it on top of release-3.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
1 similar comment
|
/retest |
|
@sdodson Can you tag this for merge again? It lost the tag when I rebased. |
|
/lgtm |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest |
|
@spadgett: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue. |
|
@spadgett: new pull request created: #7346 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The console is changing to discover if the template service broker is
running by looking at the service classes on the client. This means the
console no longer needs the RBAC template. It also no longer needs to
manually trigger a rollout after the template service broker is
installed or removed.
Requires:
openshift/origin-web-console-server#31
openshift/origin-web-console#2800
openshift/origin-web-catalog#642
Corresponding origin PR:
openshift/origin#18580
This will fail tests until the origin-web-console image is updated with the changes in the origin-web-console-server PR.
/assign @sdodson
@deads2k cc