Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check service classes to see if template service broker is enabled #2800

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Feb 12, 2018

Requires openshift/origin-web-catalog#642

Bump origin-web-common to v3.9.0-alpha.12
Bump origin-web-catalog to v3.9.0-alpha.14

/assign @dtaylor113

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2018
Bump origin-web-common to v3.9.0-alpha.12
Bump origin-web-catalog to v3.9.0-alpha.14
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2018
@spadgett spadgett changed the title [WIP] Check service classes to see if template service broker is enabled Check service classes to see if template service broker is enabled Feb 12, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2018
@spadgett spadgett added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2018
@spadgett
Copy link
Member Author

flake #2105

/retest

@spadgett
Copy link
Member Author

still looks like flake #2105

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 462a476 into openshift:master Feb 13, 2018
@spadgett spadgett deleted the check-tsb-enabled branch February 13, 2018 01:12
openshift-merge-robot added a commit to openshift/openshift-ansible that referenced this pull request Mar 1, 2018
Automatic merge from submit-queue.

Remove RBAC console template

The console is changing to discover if the template service broker is
running by looking at the service classes on the client. This means the
console no longer needs the RBAC template. It also no longer needs to
manually trigger a rollout after the template service broker is
installed or removed.

Requires:

openshift/origin-web-console-server#31
openshift/origin-web-console#2800
openshift/origin-web-catalog#642

Corresponding origin PR:

openshift/origin#18580

This will fail tests until the origin-web-console image is updated with the changes in the origin-web-console-server PR.

/assign @sdodson 
@deads2k cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants