Check service classes to determine if template service broker is enabled #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
dtaylor113
approved these changes
Feb 12, 2018
This was referenced Feb 12, 2018
Check service classes to see if template service broker is enabled
openshift/origin-web-console#2800
Merged
openshift-merge-robot
added a commit
to openshift/origin-web-console
that referenced
this pull request
Feb 13, 2018
Automatic merge from submit-queue. Check service classes to see if template service broker is enabled Requires openshift/origin-web-catalog#642 Bump origin-web-common to v3.9.0-alpha.12 Bump origin-web-catalog to v3.9.0-alpha.14 /assign @dtaylor113
openshift-merge-robot
added a commit
to openshift/openshift-ansible
that referenced
this pull request
Mar 1, 2018
Automatic merge from submit-queue. Remove RBAC console template The console is changing to discover if the template service broker is running by looking at the service classes on the client. This means the console no longer needs the RBAC template. It also no longer needs to manually trigger a rollout after the template service broker is installed or removed. Requires: openshift/origin-web-console-server#31 openshift/origin-web-console#2800 openshift/origin-web-catalog#642 Corresponding origin PR: openshift/origin#18580 This will fail tests until the origin-web-console image is updated with the changes in the origin-web-console-server PR. /assign @sdodson @deads2k cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps remove one possible cause of openshift/origin#18569 since we won't need to check for the template service broker on pod startup.
/assign @dtaylor113
@deads2k @jwforres cc