Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "allow webconsole to discover cluster information" #18580

Merged

Conversation

spadgett
Copy link
Member

This reverts commit 98b9fa6.

/assign @deads2k
/hold

Requires openshift/origin-web-console-server#31

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2018
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 12, 2018
@deads2k
Copy link
Contributor

deads2k commented Feb 13, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, spadgett

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2018
@spadgett
Copy link
Member Author

@deads2k Thanks. If you're good with openshift/origin-web-console-server#31 can you tag that one too? It needs to go in first.

@spadgett
Copy link
Member Author

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2018
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

openshift/origin-web-console-server#31 has merged, but we're still waiting on a new origin-web-console image, which is why tests are failing.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit b547bd2 into openshift:master Feb 19, 2018
@spadgett spadgett deleted the remove-console-rbac-template branch February 23, 2018 17:06
openshift-merge-robot added a commit to openshift/openshift-ansible that referenced this pull request Mar 1, 2018
Automatic merge from submit-queue.

Remove RBAC console template

The console is changing to discover if the template service broker is
running by looking at the service classes on the client. This means the
console no longer needs the RBAC template. It also no longer needs to
manually trigger a rollout after the template service broker is
installed or removed.

Requires:

openshift/origin-web-console-server#31
openshift/origin-web-console#2800
openshift/origin-web-catalog#642

Corresponding origin PR:

openshift/origin#18580

This will fail tests until the origin-web-console image is updated with the changes in the origin-web-console-server PR.

/assign @sdodson 
@deads2k cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants