-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "allow webconsole to discover cluster information" #18580
Revert "allow webconsole to discover cluster information" #18580
Conversation
This reverts commit 98b9fa6.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, spadgett The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@deads2k Thanks. If you're good with openshift/origin-web-console-server#31 can you tag that one too? It needs to go in first. |
/hold cancel |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
openshift/origin-web-console-server#31 has merged, but we're still waiting on a new origin-web-console image, which is why tests are failing. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Automatic merge from submit-queue. |
Automatic merge from submit-queue. Remove RBAC console template The console is changing to discover if the template service broker is running by looking at the service classes on the client. This means the console no longer needs the RBAC template. It also no longer needs to manually trigger a rollout after the template service broker is installed or removed. Requires: openshift/origin-web-console-server#31 openshift/origin-web-console#2800 openshift/origin-web-catalog#642 Corresponding origin PR: openshift/origin#18580 This will fail tests until the origin-web-console image is updated with the changes in the origin-web-console-server PR. /assign @sdodson @deads2k cc
This reverts commit 98b9fa6.
/assign @deads2k
/hold
Requires openshift/origin-web-console-server#31